Correct typographical error in DTED Level 2 RPF#20
Merged
emxsys merged 1 commit intoWorldWindEarth:developfrom Apr 12, 2019
Merged
Correct typographical error in DTED Level 2 RPF#20emxsys merged 1 commit intoWorldWindEarth:developfrom
emxsys merged 1 commit intoWorldWindEarth:developfrom
Conversation
Member
Author
|
@emxsys, this looks like an oversight in the original code, but I'm not sure as I'm unfamiliar with RPFDataSeries class. Does the fix look OK to you? |
Member
|
@wcmatthysen I have some RPF data that I will examine. |
emxsys
approved these changes
Apr 12, 2019
Member
emxsys
left a comment
emxsys
left a comment
There was a problem hiding this comment.
I don't have any RPF DTED data for verification. The patterns in the RPFDataSeries certainly indicate a typo for DATA_SERIES_D2. The change looks OK to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Migrated the original pull-request from @rhstone (see pull-request: NASAWorldWind#98 and the corresponding issue: NASAWorldWind#99). According to the original forum-post:
Why Should This Be In Core?
This fixes a bug where WorldWind displays the wrong altitude for two different DTED levels. Looks like a small oversight in the original code.
Benefits
Correct altitude values are displayed for DTED levels.
Potential Drawbacks
None
Applicable Issues
None